Review Request 127486: Fix uninitialized int array in UnicodeGroupProber

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127486/
-----------------------------------------------------------

(Updated March 29, 2016, 3:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 1e8b5370ddd2751d00ef823840077ae1562faf52 by Dominik Haumann to branch master.


Bugs: 357341
    https://bugs.kde.org/show_bug.cgi?id=357341


Repository: kcodecs


Description
-------

When loading the file from bug https://bugs.kde.org/show_bug.cgi?id=360797 with kwrite one gets a segfault. Valgrind tells us 'count' is uninitialized (see line 83).

This patch
- moves variables to local scopes
- initializes the variable count with 5 times 0.

The backtrace in bug https://bugs.kde.org/show_bug.cgi?id=357341 is fixed this way. However, there is a second crash still happening, which still needs investigation.


Diffs
-----

  src/probers/UnicodeGroupProber.cpp 1d86f08 

Diff: https://git.reviewboard.kde.org/r/127486/diff/


Testing
-------

- unit tests still pass
- The encoding prober does not crash at the location anymore - it crashes a bit later (another issue)


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160329/46624d0f/attachment-0001.html>