Review Request 127486: Fix uninitialized int array in UnicodeGroupProber
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Mar 29 15:45:06 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127486/#review94108
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 25, 2016, 5:53 p.m., Dominik Haumann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127486/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 5:53 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 357341
> https://bugs.kde.org/show_bug.cgi?id=357341
>
>
> Repository: kcodecs
>
>
> Description
> -------
>
> When loading the file from bug https://bugs.kde.org/show_bug.cgi?id=360797 with kwrite one gets a segfault. Valgrind tells us 'count' is uninitialized (see line 83).
>
> This patch
> - moves variables to local scopes
> - initializes the variable count with 5 times 0.
>
> The backtrace in bug https://bugs.kde.org/show_bug.cgi?id=357341 is fixed this way. However, there is a second crash still happening, which still needs investigation.
>
>
> Diffs
> -----
>
> src/probers/UnicodeGroupProber.cpp 1d86f08
>
> Diff: https://git.reviewboard.kde.org/r/127486/diff/
>
>
> Testing
> -------
>
> - unit tests still pass
> - The encoding prober does not crash at the location anymore - it crashes a bit later (another issue)
>
>
> Thanks,
>
> Dominik Haumann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160329/591ddc90/attachment.html>
More information about the Kde-frameworks-devel
mailing list