Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

[Dominik Haumann]

> On March 26, 2016, 12:55 p.m., Dominik Haumann wrote:
> > This issue was just fixed by Kare, see kwrite-devel mailing list and commit
> > https://quickgit.kde.org/?p=ktexteditor.git&a=commit&h=f7f330b21aa394a62ac95ea9bee075f372ff6d9c
> > 
> > A bug was introduced in clazy commits, unfortunately, this bug is also in the latest frameworks release.
> > 
> > Thanks for looking into this, though.
> > However, since this is fixed now, please discard this review request, the code is correct as is.
> 
> Anthony Fieroni wrote:
>     Ok, i notice other issue, now look on it. Type in katecomplationwidget.cpp 'm_viewb' and type backspace => completion is aborted and it has a flickert widget type one more time backspace and width of completion widget is not correct calculated.
> 
> Anthony Fieroni wrote:
>     The code is too complex, i will reported in kdebugs if you not notice it
>     https://i.imgur.com/iUrg2V4.png

Can you please move this discussion to kwrite-devel at kde.org or the bug tracker, since it is unrelated to this review request?
There, it is also much more likely that the relevant developers read your mail :-)


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127497/#review94022
-----------------------------------------------------------


On March 26, 2016, 1:19 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127497/
> -----------------------------------------------------------
> 
> (Updated March 26, 2016, 1:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Selection must be cleared with redraw. Below comment says: "don't redraw the cleared selection - that's done in editEnd()." -> this is not true, i don't see any code to clear selection, i may wrong
> 
> 
> Diffs
> -----
> 
>   src/view/kateview.cpp aadc42b 
> 
> Diff: https://git.reviewboard.kde.org/r/127497/diff/
> 
> 
> Testing
> -------
> 
> Screenshot to prove
> 
> 
> File Attachments
> ----------------
> 
> Selection stays above and below cursor line
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/26/8154d84d-d858-46c1-956b-290ea604984a__Screenshot_20160326_091738.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160326/4b1d3a5d/attachment.html>