Review Request 127497: [clearSelection] Selection is not cleared, arbitrary

Anthony Fieroni bvbfan at abv.bg
Sat Mar 26 13:19:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127497/
-----------------------------------------------------------

(Updated Март 26, 2016, 3:19 след обяд)


Status
------

This change has been discarded.


Review request for KDE Frameworks and Christoph Cullmann.


Repository: ktexteditor


Description
-------

Selection must be cleared with redraw. Below comment says: "don't redraw the cleared selection - that's done in editEnd()." -> this is not true, i don't see any code to clear selection, i may wrong


Diffs
-----

  src/view/kateview.cpp aadc42b 

Diff: https://git.reviewboard.kde.org/r/127497/diff/


Testing
-------

Screenshot to prove


File Attachments
----------------

Selection stays above and below cursor line
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/26/8154d84d-d858-46c1-956b-290ea604984a__Screenshot_20160326_091738.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160326/8e74252c/attachment.html>


More information about the Kde-frameworks-devel mailing list