Review Request 127424: KCompletionBox popup gets full window decoration on Windows

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127424/
-----------------------------------------------------------

(Updated March 25, 2016, 9:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin, kwin, and Marco Martin.


Changes
-------

Submitted with commit 906e6a1409389c5abc501f0172c5dff21fdc6edd by Dominik Haumann to branch master.


Repository: kcompletion


Description
-------

In https://git.reviewboard.kde.org/r/127191/ the KCompletionBox WindowFlags were change from Qt::ToolTip to Qt::Window.

As consequence, the completion popup of the Kate command line gets a full window decoration, which is obviously wrong, see attached screenshot.

Changing the type to Qt::Popup shows the proper popup, but key presses are not forwarded, so typing is not possible, and additionally, on losing focus the popup keeps staying open.
Therefore, this patch reverts the type back to Qt::ToolTip.

Better fixes are of course welcome ;) Any ideas?


Diffs
-----

  src/kcompletionbox.cpp 005aff8 

Diff: https://git.reviewboard.kde.org/r/127424/diff/


Testing
-------

Works on Windows as expected.


File Attachments
----------------

Completion Popup
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/7be64cad-6d95-46b8-9caa-41b41a135ca1__kate2015.png


Thanks,

Dominik Haumann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160325/e42366e9/attachment.html>