Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.
David Faure
faure at kde.org
Sat Mar 19 20:31:40 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127428/
-----------------------------------------------------------
Review request for KDE Frameworks.
Repository: kemoticons
Description
-------
Noticed in the CI which says: Invalid plugin factory for "kf5/emoticonsthemes/kde"
Diffs
-----
src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0
Diff: https://git.reviewboard.kde.org/r/127428/diff/
Testing
-------
Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash too, this fixes it.
Of course the unittest fails then, as expected, it just doesn't crash anymore.
I think some env vars are missing in Jenkins....
Thanks,
David Faure
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160319/dd005c1d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list