Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

Kåre Särs kare.sars at iki.fi
Tue Mar 22 16:53:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/
-----------------------------------------------------------

(Updated March 22, 2016, 4:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 7ac7a605923f0bb2f0f367f6069a101a24bead9f by Kåre Särs to branch master.


Repository: kcoreaddons


Description
-------

Without this patch kcoreaddons_desktop_to_json() will not find the service type destop file.

On windows GenericDataLocation returns "C:/Users/<USER>/AppData/Local" or "C:/ProgramData". That is not a path that contains any destop files ;)

This patch adds KDE_INSTALL_FULL_KSERVICETYPES5DIR as fist item in the search paths and if not found searches like before.


Diffs
-----

  KF5CoreAddonsMacros.cmake 5d8e3d4 

Diff: https://git.reviewboard.kde.org/r/126618/diff/


Testing
-------

KTextEditor compiles on windows


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160322/9e63ef57/attachment.html>


More information about the Kde-frameworks-devel mailing list