Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.
David Faure
faure at kde.org
Sun Mar 20 09:54:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/#review93761
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On March 11, 2016, 8:19 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126618/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 8:19 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Without this patch kcoreaddons_desktop_to_json() will not find the service type destop file.
>
> On windows GenericDataLocation returns "C:/Users/<USER>/AppData/Local" or "C:/ProgramData". That is not a path that contains any destop files ;)
>
> This patch adds KDE_INSTALL_FULL_KSERVICETYPES5DIR as fist item in the search paths and if not found searches like before.
>
>
> Diffs
> -----
>
> KF5CoreAddonsMacros.cmake 5d8e3d4
>
> Diff: https://git.reviewboard.kde.org/r/126618/diff/
>
>
> Testing
> -------
>
> KTextEditor compiles on windows
>
>
> Thanks,
>
> Kåre Särs
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160320/6b844cf9/attachment.html>
More information about the Kde-frameworks-devel
mailing list