Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127398/
-----------------------------------------------------------

(Updated March 21, 2016, 10:59 p.m.)


Review request for KDE Frameworks.


Changes
-------

Start assigning the ids at 0 rather than 1 with -1 still being invalid.

There's now a special test for the ids but it's limited as there's currently
no way to test the id changes other than those two. This would require a special
signal being useful only for the test, which I'm not sure is good to add?


Repository: knotifications


Description
-------

Adds basic set of unit tests including fake notifications server.

This helped uncover and fix these issues:

* Calling close() on KNotification that was not "sent" would not emit closed() and would not delete it
* Closing a notification can delete the KNotification object prematurely
* Invoking an action leads to unnecessary dbus roundtrip
* Invoking an action would fail to properly close and delete the KNotification object


Diffs (updated)
-----

  CMakeLists.txt 51f6c22 
  autotests/CMakeLists.txt PRE-CREATION 
  autotests/fake_notifications_server.h PRE-CREATION 
  autotests/fake_notifications_server.cpp PRE-CREATION 
  autotests/knotification_test.cpp PRE-CREATION 
  autotests/knotifications5/qttest.notifyrc PRE-CREATION 
  autotests/qtest_dbus.h PRE-CREATION 
  src/knotification.cpp 17b0be2 
  src/knotificationmanager.cpp e80d48c 
  src/knotificationplugin.cpp acf964c 
  src/notifybypopup.cpp c0050b2 

Diff: https://git.reviewboard.kde.org/r/127398/diff/


Testing
-------

Unit tests all pass.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160321/d107f0a1/attachment-0001.html>