<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127398/">https://git.reviewboard.kde.org/r/127398/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated March 21, 2016, 10:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Start assigning the ids at 0 rather than 1 with -1 still being invalid.
There's now a special test for the ids but it's limited as there's currently
no way to test the id changes other than those two. This would require a special
signal being useful only for the test, which I'm not sure is good to add?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds basic set of unit tests including fake notifications server.
This helped uncover and fix these issues:
* Calling close() on KNotification that was not "sent" would not emit closed() and would not delete it
* Closing a notification can delete the KNotification object prematurely
* Invoking an action leads to unnecessary dbus roundtrip
* Invoking an action would fail to properly close and delete the KNotification object</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit tests all pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(51f6c22)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fake_notifications_server.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/fake_notifications_server.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/knotification_test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/knotifications5/qttest.notifyrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/qtest_dbus.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotification.cpp <span style="color: grey">(17b0be2)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(e80d48c)</span></li>
<li>src/knotificationplugin.cpp <span style="color: grey">(acf964c)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(c0050b2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>