Review Request 127410: Fix crash in rename dialog (KF 5.20)
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sat Mar 19 11:23:28 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/
-----------------------------------------------------------
(Updated March 19, 2016, 11:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
Changes
-------
Submitted with commit bf37e9aa27a2321f4a6ce7188a0901fabd47c962 by Emmanuel Pescosta to branch master.
Bugs: 360488
https://bugs.kde.org/show_bug.cgi?id=360488
Repository: kio
Description
-------
Fix crash in rename dialog
ResizePanels must only be called in case of overwrite, all other cases violate the preconditions.
@Andreas: Can you please try the patch?
Diffs
-----
src/widgets/renamedialog.cpp 2d456c7
Diff: https://git.reviewboard.kde.org/r/127410/diff/
Testing
-------
Yes, I tried it by overwriting a file with the same file and with a different file -> no crash :)
Thanks,
Emmanuel Pescosta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160319/815c579e/attachment.html>
More information about the Kde-frameworks-devel
mailing list