Review Request 127410: Fix crash in rename dialog (KF 5.20)
David Faure
faure at kde.org
Sat Mar 19 11:02:41 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127410/#review93710
-----------------------------------------------------------
Ship it!
Oops, thanks for the fix.
- David Faure
On March 17, 2016, 9:37 a.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127410/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 9:37 a.m.)
>
>
> Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.
>
>
> Bugs: 360488
> https://bugs.kde.org/show_bug.cgi?id=360488
>
>
> Repository: kio
>
>
> Description
> -------
>
> Fix crash in rename dialog
>
> ResizePanels must only be called in case of overwrite, all other cases violate the preconditions.
>
> @Andreas: Can you please try the patch?
>
>
> Diffs
> -----
>
> src/widgets/renamedialog.cpp 2d456c7
>
> Diff: https://git.reviewboard.kde.org/r/127410/diff/
>
>
> Testing
> -------
>
> Yes, I tried it by overwriting a file with the same file and with a different file -> no crash :)
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160319/013352c3/attachment.html>
More information about the Kde-frameworks-devel
mailing list