Review Request 127405: Make sure PlasmaQuick export file is properly found

Aleix Pol Gonzalez aleixpol at kde.org
Thu Mar 17 12:37:02 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/
-----------------------------------------------------------

(Updated March 17, 2016, 1:37 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Include export files as suggested by Marco.


Repository: plasma-framework


Description
-------

Uses `"quotes"` rather than `<brackets>` to include a neigbour header file.


Diffs (updated)
-----

  src/plasmaquick/appletquickitem.h 99fcf1b 
  src/plasmaquick/configmodel.h ed2df2e 
  src/plasmaquick/configview.h 5ac9c26 
  src/plasmaquick/dialog.h 63efa04 
  src/plasmaquick/packageurlinterceptor.h 343e311 
  src/plasmaquick/shellpluginloader.h bdc13be 
  src/plasmaquick/view.h b59271d 

Diff: https://git.reviewboard.kde.org/r/127405/diff/


Testing
-------

Aparently it was a problem on some systems. It was eventually fixed for me, so I thought I was crazy. This should be the fix nevertheless (assuming include directories are being exported properly).


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160317/98a0cf18/attachment.html>


More information about the Kde-frameworks-devel mailing list