Review Request 127405: Make sure PlasmaQuick export file is properly found
Marco Martin
notmart at gmail.com
Thu Mar 17 12:15:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/#review93649
-----------------------------------------------------------
src/plasmaquick/appletquickitem.h (line 31)
<https://git.reviewboard.kde.org/r/127405/#comment63857>
they're installed headers, so i think it should be
#include <plasmaquick/plasmaquick_export.h>
- Marco Martin
On March 17, 2016, 12:16 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127405/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 12:16 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Uses `"quotes"` rather than `<brackets>` to include a neigbour header file.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.h 99fcf1b
> src/plasmaquick/configmodel.h ed2df2e
> src/plasmaquick/configview.h 5ac9c26
> src/plasmaquick/containmentview.h 4bdc1de
> src/plasmaquick/dialog.h 63efa04
> src/plasmaquick/packageurlinterceptor.h 343e311
> src/plasmaquick/shellpluginloader.h bdc13be
> src/plasmaquick/view.h b59271d
>
> Diff: https://git.reviewboard.kde.org/r/127405/diff/
>
>
> Testing
> -------
>
> Aparently it was a problem on some systems. It was eventually fixed for me, so I thought I was crazy. This should be the fix nevertheless (assuming include directories are being exported properly).
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160317/0cd07f42/attachment.html>
More information about the Kde-frameworks-devel
mailing list