Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

Martin Klapetek martin.klapetek at gmail.com
Mon Mar 14 12:29:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127348/
-----------------------------------------------------------

(Updated March 14, 2016, 1:29 p.m.)


Review request for KDE Frameworks and KDEPIM.


Changes
-------

Now with a test


Repository: kpeople


Description
-------

For single contact without any person, PersonData does not work. This uses the contact uri as a person uri in that case, making things work. It also mirrors what PersonsModel does.


Diffs (updated)
-----

  autotests/persondatatests.cpp 5f7cabd 
  src/persondata.cpp 4586bac 

Diff: https://git.reviewboard.kde.org/r/127348/diff/


Testing
-------

PersonData returns correct data


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160314/ab151bb7/attachment.html>


More information about the Kde-frameworks-devel mailing list