Review Request 127348: [KPeople] Set the contact uri as person uri in PersonData when no person exists

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127348/#review93427
-----------------------------------------------------------



Can you add a test case for the `PersonDataTests`?

- Aleix Pol Gonzalez


On March 11, 2016, 11:51 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127348/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 11:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> For single contact without any person, PersonData does not work. This uses the contact uri as a person uri in that case, making things work. It also mirrors what PersonsModel does.
> 
> 
> Diffs
> -----
> 
>   src/persondata.cpp 4586bac 
> 
> Diff: https://git.reviewboard.kde.org/r/127348/diff/
> 
> 
> Testing
> -------
> 
> PersonData returns correct data
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160312/bda656f7/attachment.html>