Review Request 127345: Make it possible for an applet to offer a test object

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93422
-----------------------------------------------------------




src/plasmaquick/appletquickitem.h (line 130)
<https://git.reviewboard.kde.org/r/127345/#comment63685>

    you don't really need this
    http://doc.qt.io/qt-5/qqmlengine.html#qmlEngine



src/plasmaquick/appletquickitem.cpp (line 648)
<https://git.reviewboard.kde.org/r/127345/#comment63686>

    who will be using this? from the shell?


- Marco Martin


On March 11, 2016, 8:26 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 8:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In an attempt to make it possible for plasmoid to test themselves in the different shells, provide API to exatract the object that will test the plasmoid instance.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160311/f941a76c/attachment-0001.html>