Review Request 127345: Make it possible for an applet to offer a test object

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93419
-----------------------------------------------------------



I have a rough idea how you want it to work, but to really evaluate the patch, I need to understand the bigger picture.

Some smallish issues pointed out inline.


src/plasmaquick/appletquickitem.h (line 31)
<https://git.reviewboard.kde.org/r/127345/#comment63681>

    unrelated?
    
    (IMO no need to make another patch for it, just checking.)



src/plasmaquick/appletquickitem.h (line 129)
<https://git.reviewboard.kde.org/r/127345/#comment63682>

    teh mistake!



src/plasmaquick/appletquickitem.cpp (line 652)
<https://git.reviewboard.kde.org/r/127345/#comment63683>

    { } also for single lines


- Sebastian Kügler


On March 11, 2016, 8:26 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127345/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 8:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In an attempt to make it possible for plasmoid to test themselves in the different shells, provide API to exatract the object that will test the plasmoid instance.
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/packages.cpp a5ba81a 
>   src/plasmaquick/appletquickitem.h 4f25f5d 
>   src/plasmaquick/appletquickitem.cpp 9242e9e 
>   src/plasmaquick/private/appletquickitem_p.h 9c24734 
> 
> Diff: https://git.reviewboard.kde.org/r/127345/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160311/89cd4736/attachment.html>