Review Request 127191: KCompletionBox should *not* be a tooltip

[Thomas Lübking]

> On Feb. 26, 2016, 2:14 p.m., Thomas Lübking wrote:
> > src/kcompletionbox.cpp, line 66
> > <https://git.reviewboard.kde.org/r/127191/diff/1/?file=445519#file445519line66>
> >
> >     q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken??
> 
> Marco Martin wrote:
>     ok, i'm blind :p
> 
> Martin Gräßlin wrote:
>     cd src/qt5/qtbase/src/plugins/platforms/xcb
>     git grep X11NetWmWindowTypeCombo
>     
>     -> no result
>     
>     I doubt this still works...
> 
> Marco Martin wrote:
>     yep, indeed i get type normal now, getting back on the first approach

QComboBox still sets the attribute but it's in a "Q_DEAD_CODE_FROM_QT4_X11" preproc branch.
Qt5 is a piece of broken shit - seriously!


QComboBox would then fall to ::setWindowFlags(Qt::Popup) but actually that's not worth it at all. The target is QML + Phones, the rest of Qt is apparently now unmaintained junk.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127191/#review92809
-----------------------------------------------------------


On March 7, 2016, 11:35 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127191/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 11:35 a.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> -------
> 
> KCompletionbox it's actually more of  a combobox popup than a tooltip.
> this sets it the proper type (unfortunately with an hack due the type not being available to Qt::WindowFlags)
> 
> without this, the new morphingpopups KWin effect will animate completion boxes (such as in file open dialog, kate, dolphin adress bar etc)
> 
> 
> Diffs
> -----
> 
>   src/kcompletionbox.cpp 99afc8e 
> 
> Diff: https://git.reviewboard.kde.org/r/127191/diff/
> 
> 
> Testing
> -------
> 
> Same behavior, due to the Window and bypasswindowmanager that are those two that made the desired behavior when tooltip was picked
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160307/27667824/attachment.html>