Review Request 127191: KCompletionBox should *not* be a tooltip

Marco Martin notmart at gmail.com
Mon Mar 7 11:35:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127191/
-----------------------------------------------------------

(Updated March 7, 2016, 11:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kwin.


Changes
-------

Submitted with commit a4aced126beb14adc539edcb21e2423dd82ab6b0 by Marco Martin to branch master.


Repository: kcompletion


Description
-------

KCompletionbox it's actually more of  a combobox popup than a tooltip.
this sets it the proper type (unfortunately with an hack due the type not being available to Qt::WindowFlags)

without this, the new morphingpopups KWin effect will animate completion boxes (such as in file open dialog, kate, dolphin adress bar etc)


Diffs
-----

  src/kcompletionbox.cpp 99afc8e 

Diff: https://git.reviewboard.kde.org/r/127191/diff/


Testing
-------

Same behavior, due to the Window and bypasswindowmanager that are those two that made the desired behavior when tooltip was picked


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160307/2aa5a9a5/attachment.html>


More information about the Kde-frameworks-devel mailing list