Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

[Jean-Baptiste Mardelle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/
-----------------------------------------------------------

(Updated March 5, 2016, 8:01 p.m.)


Review request for KDE Frameworks and David Faure.


Bugs: 352882
    https://bugs.kde.org/show_bug.cgi?id=352882


Repository: kxmlgui


Description
-------

To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
1 - Change the main toolbar setting. 
2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, allowing main app to re-plug its dynamic actions
3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot re-plug actions, and they are lost.

The problem only happens if you click "apply" and then "ok". This is due to the fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui rebuild), but signal is not emitted.

My solution is to rebuild ui only if something changed when clicking "ok".


Diffs (updated)
-----

  src/kedittoolbar.cpp b6842f6 
  src/kedittoolbar_p.h 73152ef 

Diff: https://git.reviewboard.kde.org/r/126184/diff/


Testing
-------

Tested, fixes the reported problem.


Thanks,

Jean-Baptiste Mardelle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160305/e490cace/attachment.html>