Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions
David Faure
faure at kde.org
Sat Mar 5 09:36:26 UTC 2016
> On Dec. 6, 2015, 2:58 p.m., David Faure wrote:
> > src/kedittoolbar.cpp, line 770
> > <https://git.reviewboard.kde.org/r/126184/diff/1/?file=418635#file418635line770>
> >
> > this code path didn't call accept() before.
> >
> > Please investigate when save can fail, or keep former behaviour (by adding "return;").
OK, save() always returns true, you could just clean up the test for the save() ret val and change that method to void. Thanks.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/#review89183
-----------------------------------------------------------
On Nov. 27, 2015, 1:40 p.m., Jean-Baptiste Mardelle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126184/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 1:40 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 352882
> https://bugs.kde.org/show_bug.cgi?id=352882
>
>
> Repository: kxmlgui
>
>
> Description
> -------
>
> To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
> 1 - Change the main toolbar setting.
> 2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, allowing main app to re-plug its dynamic actions
> 3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot re-plug actions, and they are lost.
>
> The problem only happens if you click "apply" and then "ok". This is due to the fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui rebuild), but signal is not emitted.
>
> My solution is to rebuild ui only if something changed when clicking "ok".
>
>
> Diffs
> -----
>
> src/kedittoolbar.cpp ba4ba0f
>
> Diff: https://git.reviewboard.kde.org/r/126184/diff/
>
>
> Testing
> -------
>
> Tested, fixes the reported problem.
>
>
> Thanks,
>
> Jean-Baptiste Mardelle
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160305/cd22bbe7/attachment.html>
More information about the Kde-frameworks-devel
mailing list