gcode.xml got into KF5::KTextEditor without review

Alexander Potashev aspotashev at gmail.com
Sat Mar 5 00:01:34 UTC 2016


Hi everyone, (Sven),

As I understand, KF5 does not have feature freezes because all changes
are unit-tested and reviewed [1].

[2] is clearly a feature, but it was not submitted to reviewboard
before pushing to ktexteditor.git:master. This change also introduced
a new string for translators: "G-Code", thus it breaks the actual
2-week string freeze [1].

Please consider reverting and starting a new review request at
http://git.reviewboard.kde.org/


P.S.  Yes, I am nitpicking. Someone has to do it.

[1] https://techbase.kde.org/Schedules/Frameworks
[2] http://commits.kde.org/ktexteditor/c65cdf81660eca01ab3d0792944a2e96a365bbca

-- 
Alexander Potashev


More information about the Kde-frameworks-devel mailing list