Review Request 127240: [Applet] Don't crash on remove panel

[David Edmundson]

> On March 1, 2016, 4:02 p.m., David Edmundson wrote:
> > src/plasma/private/applet_p.cpp, line 327
> > <https://git.reviewboard.kde.org/r/127240/diff/2/?file=446202#file446202line327>
> >
> >     Why is this change "the else" here?
> >     
> >     you've changed it 
> >     
> >     if the timeout happens but the notification is still present, simply don't remove the panel.
> 
> Anthony Fieroni wrote:
>     This is because notification is KNotification::Persistent i.e. forever, timer is to stop notify user. Since we stop notified him, last his disitioin is to remove the panel. *Else* branch is corerct.

1) If it is a correct change, it needs to be in the commit message description saying what and why. 


2) It isn't correct. Re-read it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/#review93015
-----------------------------------------------------------


On March 1, 2016, 2:30 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127240/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 2:30 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco Martin.
> 
> 
> Bugs: 345723
>     http://bugs.kde.org/show_bug.cgi?id=345723
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Stop timer is any case, if you don't want *this* to be nullptr
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/applet_p.cpp 38d486a 
> 
> Diff: https://git.reviewboard.kde.org/r/127240/diff/
> 
> 
> Testing
> -------
> 
> Still not tested, but look good for me.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/41879b1b/attachment.html>