Review Request 127240: [Applet] Don't crash on remove panel
David Edmundson
david at davidedmundson.co.uk
Tue Mar 1 16:02:36 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/#review93015
-----------------------------------------------------------
src/plasma/private/applet_p.cpp (line 326)
<https://git.reviewboard.kde.org/r/127240/#comment63445>
Why is this change "the else" here?
you've changed it
if the timeout happens but the notification is still present, simply don't remove the panel.
- David Edmundson
On March 1, 2016, 2:30 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127240/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 2:30 p.m.)
>
>
> Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco Martin.
>
>
> Bugs: 345723
> http://bugs.kde.org/show_bug.cgi?id=345723
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Stop timer is any case, if you don't want *this* to be nullptr
>
>
> Diffs
> -----
>
> src/plasma/private/applet_p.cpp 38d486a
>
> Diff: https://git.reviewboard.kde.org/r/127240/diff/
>
>
> Testing
> -------
>
> Still not tested, but look good for me.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/a299da4f/attachment.html>
More information about the Kde-frameworks-devel
mailing list