Review Request 127237: Fix crash in kmore tools when DBus is missing
Kåre Särs
kare.sars at iki.fi
Tue Mar 1 06:50:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127237/
-----------------------------------------------------------
Review request for KDE Frameworks and Gregor Mi.
Repository: knewstuff
Description
-------
If DBus is missing we get null-pointers in stead of KMoreToolsService*. This patch adds checks for null-pointers in those places that made Kate crash in the project plugin.
Diffs
-----
src/kmoretools/kmoretoolsmenufactory.cpp 30f4d02
src/kmoretools/kmoretoolspresets.cpp 2405321
Diff: https://git.reviewboard.kde.org/r/127237/diff/
Testing
-------
Compiled and run on windows. No crashes in Kate when running without DBus and right-clicking files in the project plugin.
Thanks,
Kåre Särs
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/d8bdd880/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list