Review Request 127211: Properly use static QMaps

Aleix Pol Gonzalez aleixpol at kde.org
Tue Mar 1 03:26:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127211/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 7:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kate and KDE Frameworks.


Changes
-------

Submitted with commit 58c0beb95b05a7963d4151a48c99691e10ff2bc5 by Aleix Pol to branch master.


Repository: ktexteditor


Description
-------

Only initialize them once.
Since they're not const, use ::value rather than ::operator[], because the latter will provide a default-constructed object and add it to the map.


Diffs
-----

  src/vimode/cmds.cpp 7804af4 

Diff: https://git.reviewboard.kde.org/r/127211/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160301/40c98d21/attachment.html>


More information about the Kde-frameworks-devel mailing list