Review Request 128319: Fix memory leaks in the properties dialog
Elvis Angelaccio
elvis.angelaccio at kdemail.net
Wed Jun 29 14:52:29 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128319/
-----------------------------------------------------------
(Updated June 29, 2016, 2:52 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks and David Faure.
Repository: kio
Description
-------
I noticed these leaks while working on RR 128283. All the existing plugins create the `m_frame` widget without a parent: `d->m_frame = new QFrame();`
This widget is used as parent for many other widgets, but it's never deleted and so there is a fairly amount of memory never released to the OS.
Diffs
-----
src/widgets/kpropertiesdialog.cpp d0a2faa5114e391680925e10646ce7c6f2ea29da
Diff: https://git.reviewboard.kde.org/r/128319/diff/
Testing
-------
Thanks,
Elvis Angelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/f79dab5d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list