Review Request 128319: Fix memory leaks in the properties dialog

[Elvis Angelaccio]

> On June 29, 2016, 2:44 p.m., David Faure wrote:
> > src/widgets/kpropertiesdialog.cpp, line 825
> > <https://git.reviewboard.kde.org/r/128319/diff/1/?file=470490#file470490line825>
> >
> >     This line, here, reparents the frame to the properties dialog. There is no leak.

Oh, that explains it. Sorry for the noise...


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128319/#review96958
-----------------------------------------------------------


On June 29, 2016, 2:38 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128319/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 2:38 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> I noticed these leaks while working on RR 128283. All the existing plugins create the `m_frame` widget without a parent: `d->m_frame = new QFrame();`
> 
> This widget is used as parent for many other widgets, but it's never deleted and so there is a fairly amount of memory never released to the OS.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp d0a2faa5114e391680925e10646ce7c6f2ea29da 
> 
> Diff: https://git.reviewboard.kde.org/r/128319/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/781e623e/attachment.html>