Review Request 128316: Make use of QQuickItem::setSize instead of width and height indpedently.
Mark Gaiser
markg85 at gmail.com
Wed Jun 29 11:05:17 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128316/#review96951
-----------------------------------------------------------
Ship it!
I think you found an undocumented feature.
The docs don't mention it, not even in the list of all members + inherited ones: http://doc.qt.io/qt-5/qquickitem-members.html
But if i add a QQuickItem in my project and look up the setSize member, it just exists. It's part of QQuickItem.h
So looks OK to me and a nice improvement as well!
I will report a bug against Qt notifying them about this missing function in the documentation.
- Mark Gaiser
On jun 29, 2016, 10:40 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128316/
> -----------------------------------------------------------
>
> (Updated jun 29, 2016, 10:40 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Even though QQuickItem only has a width and height accessor there is a
> usable public setSize method.
>
> This gets rid of a lot of potential pointless re-evaluation as internal geometry
> is updated before widthChanged is emitted.
>
>
> Diffs
> -----
>
> src/plasmaquick/appletquickitem.cpp a9d044b1b50eace5d20441700eba3733c14b1ffd
> src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7
> src/scriptengines/qml/plasmoid/wallpaperinterface.cpp adacbe19c3f306cf442850d45fed2933e48e6b4b
>
> Diff: https://git.reviewboard.kde.org/r/128316/diff/
>
>
> Testing
> -------
>
> Restarted Plasma, everything seems normal
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/79dd19d4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list