Review Request 128316: Make use of QQuickItem::setSize instead of wight and height indpedently.
David Edmundson
david at davidedmundson.co.uk
Wed Jun 29 10:40:12 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128316/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
Even though QQuickItem only has a width and height accessor there is a
usable public setSize method.
This gets rid of a lot of potential pointless re-evaluation as internal geometry
is updated before widthChanged is emitted.
Diffs
-----
src/plasmaquick/appletquickitem.cpp a9d044b1b50eace5d20441700eba3733c14b1ffd
src/plasmaquick/configview.cpp 5c2920bdc97643a353d47d6698a56f5d898b82e7
src/scriptengines/qml/plasmoid/wallpaperinterface.cpp adacbe19c3f306cf442850d45fed2933e48e6b4b
Diff: https://git.reviewboard.kde.org/r/128316/diff/
Testing
-------
Restarted Plasma, everything seems normal
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160629/99774a9b/attachment.html>
More information about the Kde-frameworks-devel
mailing list