Review Request 128213: Fix HTML documentation generation

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128213/#review96901
-----------------------------------------------------------


Ship it!




Sorry for the delay. I would say you can commit it, it certainly improves the situation compared to the the current status. The change should be refined later to pass the proper stylesheet, see the comment inline.


KF5DocToolsMacros.cmake (line 149)
<https://git.reviewboard.kde.org/r/128213/#comment65484>

    As suggested before, you may want to pass something like:
    --stylesheet ${_sshet_standalone}
    
    and define ${_sshet_standalone} in the line before.
    
    Right now it would be the same as now (kde-chunk). The one that should be working is the kde-chunk-online available on docs.kde.org (which is slightly different from kde-chunk-online here), but the truth is that you want kde-onechunk, which does not work right now and it was hard so far to debug why it is not working. One reason more to investigate it again.


- Luigi Toscano


On Giu. 16, 2016, 6:43 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128213/
> -----------------------------------------------------------
> 
> (Updated Giu. 16, 2016, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> Fix the optional HTML documentation generation (which I would like to use for Windows/Mac)
> 
> Sidenote: The goal would be to have some html which can be used without khelpcenter and the help:/ ioslave.
> Is there some other stylesheet one could use for that?
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake e0a85b3 
> 
> Diff: https://git.reviewboard.kde.org/r/128213/diff/
> 
> 
> Testing
> -------
> 
> Before this patch: if you turn HTML docs on, not even cmake will complete, as the target names are broken.
> Now: make && make install for e.g. kate.git will create & install a index.html if HTML docs are turned on.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160627/f4490289/attachment.html>