<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128213/">https://git.reviewboard.kde.org/r/128213/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry for the delay. I would say you can commit it, it certainly improves the situation compared to the the current status. The change should be refined later to pass the proper stylesheet, see the comment inline.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128213/diff/1/?file=469062#file469062line149" style="color: black; font-weight: bold; text-decoration: underline;">KF5DocToolsMacros.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">148</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">add_custom_command</span><span class="p">(</span><span class="s">OUTPUT</span> <span class="o">${</span><span class="nv">_htmlDoc</span><span class="o">}</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">149</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">COMMAND</span> <span class="o">${</span><span class="nv">KDOCTOOLS_MEINPROC_EXECUTABLE</span><span class="o">}</span> <span class="s">--check</span> <span class="o">${</span><span class="nv">_bootstrapOption</span><span class="o">}</span> <span class="s">-o</span> <span class="o">${</span><span class="nv">build_html</span><span class="o">}</span> <span class="o">${</span><span class="nv">src_doc</span><span class="o">}</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As suggested before, you may want to pass something like:
--stylesheet ${_sshet_standalone}
and define ${_sshet_standalone} in the line before.
Right now it would be the same as now (kde-chunk). The one that should be working is the kde-chunk-online available on docs.kde.org (which is slightly different from kde-chunk-online here), but the truth is that you want kde-onechunk, which does not work right now and it was hard so far to debug why it is not working. One reason more to investigate it again.</pre>
</div>
</div>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On giugno 16th, 2016, 6:43 p.m. CEST, Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Luigi Toscano.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Giu. 16, 2016, 6:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix the optional HTML documentation generation (which I would like to use for Windows/Mac)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sidenote: The goal would be to have some html which can be used without khelpcenter and the help:/ ioslave.
Is there some other stylesheet one could use for that?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before this patch: if you turn HTML docs on, not even cmake will complete, as the target names are broken.
Now: make && make install for e.g. kate.git will create & install a index.html if HTML docs are turned on.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5DocToolsMacros.cmake <span style="color: grey">(e0a85b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>