Review Request 128283: Add checksums tab to the properties dialog

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128283/
-----------------------------------------------------------

(Updated June 27, 2016, 3:46 p.m.)


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
-------

* Added a label to explain what the user should do
* Added a label with feedback about the match/mismatch


Repository: kio


Description
-------

This patch adds a Checksums tab in the properties dialog, where the user can retrieve and verify the most popular checksum algorithms (md5, sha1 and sha256). 

To simplify the implementation, the checksums are computed as soon as the user opens the dialog. This can take a while if the file is huge (in particular with sha256), but the computation happens in another thread and in practice this should not be a performance problem.

The tab is available only for readable local files (no simlinks) and only when there is a single selection.

Please note that some of the labels in the screenshots are clipped due to a bug in breeze: https://bugs.kde.org/show_bug.cgi?id=364426


Diffs (updated)
-----

  src/widgets/CMakeLists.txt f906577 
  src/widgets/checksumswidget.ui PRE-CREATION 
  src/widgets/kpropertiesdialog.cpp d0a2faa 
  src/widgets/kpropertiesdialog_p.h c01554e 

Diff: https://git.reviewboard.kde.org/r/128283/diff/


Testing
-------

* Check whether the computed values match the values from md5sum, sha1sum, sha256sum.
* Check whether the line edits get a green background if the computed and expected values match.
* Check whether the line edits get a red background if the computed and expected values differ.


File Attachments (updated)
----------------

MD5 ready to be shared
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/26/b882fad9-85b0-4250-9743-3549339e6718__Spectacle.l10844.png
Default dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/ad06e136-7ce3-4876-a594-98fbc64f5538__Spectacle.M13222.png
Mismatch
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/99838e45-d9c5-4a14-b26a-9440f0249c4b__Spectacle.V13222.png
Match
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/519fa28f-7c7d-4bb4-bd24-622d18d7f2e2__Spectacle.v13222.png
Invalid checksum
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/27/a243c830-2dc0-4cbd-95e9-8f1684bc86a4__Spectacle.J13336.png


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160627/896767f8/attachment.html>