Review Request 128244: Use categorized debug for KCoreAddons

Michael Pyne mpyne at kde.org
Sat Jun 18 23:11:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128244/#review96701
-----------------------------------------------------------


Ship it!




Looks good to me!

- Michael Pyne


On June 18, 2016, 10:17 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128244/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 10:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> as expected
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e9e8fe4 
>   src/lib/CMakeLists.txt 466d714 
>   src/lib/caching/kshareddatacache.cpp 472eb49 
>   src/lib/caching/kshareddatacache_p.h fe1cd0f 
>   src/lib/io/kautosavefile.cpp 69bf6b4 
>   src/lib/io/kbackup.cpp 7fc197f 
>   src/lib/io/kdirwatch.cpp 9e269ee 
>   src/lib/io/kfilesystemtype.cpp 8acbb3b 
>   src/lib/plugin/kpluginfactory.cpp 9b67110 
>   src/lib/plugin/kpluginloader.h e36c9d2 
>   src/lib/plugin/kpluginloader.cpp 511f5e9 
>   src/lib/plugin/kpluginmetadata.cpp a2fd090 
>   src/lib/text/ktexttohtml.cpp fdfb28f 
>   src/lib/util/kdelibs4migration.cpp 31c111a 
>   src/lib/util/kshell_unix.cpp 8355da3 
>   src/lib/util/kuser_win.cpp 3cb0398 
> 
> Diff: https://git.reviewboard.kde.org/r/128244/diff/
> 
> 
> Testing
> -------
> 
> Builds, now I can filter.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160618/8542e784/attachment.html>


More information about the Kde-frameworks-devel mailing list