<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128244/">https://git.reviewboard.kde.org/r/128244/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me!</pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On June 18th, 2016, 10:17 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 18, 2016, 10:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as expected</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, now I can filter.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e9e8fe4)</span></li>
<li>src/lib/CMakeLists.txt <span style="color: grey">(466d714)</span></li>
<li>src/lib/caching/kshareddatacache.cpp <span style="color: grey">(472eb49)</span></li>
<li>src/lib/caching/kshareddatacache_p.h <span style="color: grey">(fe1cd0f)</span></li>
<li>src/lib/io/kautosavefile.cpp <span style="color: grey">(69bf6b4)</span></li>
<li>src/lib/io/kbackup.cpp <span style="color: grey">(7fc197f)</span></li>
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(9e269ee)</span></li>
<li>src/lib/io/kfilesystemtype.cpp <span style="color: grey">(8acbb3b)</span></li>
<li>src/lib/plugin/kpluginfactory.cpp <span style="color: grey">(9b67110)</span></li>
<li>src/lib/plugin/kpluginloader.h <span style="color: grey">(e36c9d2)</span></li>
<li>src/lib/plugin/kpluginloader.cpp <span style="color: grey">(511f5e9)</span></li>
<li>src/lib/plugin/kpluginmetadata.cpp <span style="color: grey">(a2fd090)</span></li>
<li>src/lib/text/ktexttohtml.cpp <span style="color: grey">(fdfb28f)</span></li>
<li>src/lib/util/kdelibs4migration.cpp <span style="color: grey">(31c111a)</span></li>
<li>src/lib/util/kshell_unix.cpp <span style="color: grey">(8355da3)</span></li>
<li>src/lib/util/kuser_win.cpp <span style="color: grey">(3cb0398)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128244/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>