Review Request 128233: Don't trust files claiming to be created on unix more than other files
Sune Vuorela
kde at pusling.com
Fri Jun 17 23:10:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128233/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Repository: karchive
Description
-------
Don't trust files claiming to be created on unix more than other files
For some historical reasons, we special case zip files claiming to be
created on unix and trust the content regarding file rights a bit better.
Zip files in the wild have shown to violate this, so don't trust them.
Thanks to Jonathan Marten for the test case
BUG: 364071
Diffs
-----
autotests/data/unusual_but_valid_364071.zip PRE-CREATION
autotests/karchivetest.h 4b7ecff
autotests/karchivetest.cpp c8abddf
src/kzip.cpp e7e8477
Diff: https://git.reviewboard.kde.org/r/128233/diff/
Testing
-------
Thanks,
Sune Vuorela
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160617/9a04042b/attachment.html>
More information about the Kde-frameworks-devel
mailing list