Replacing the "- name: All" platform wildcard

David Faure faure at kde.org
Wed Jun 15 14:35:01 UTC 2016


On Wednesday, June 15, 2016 10:16:19 AM CEST Andreas Cord-Landwehr wrote:
> I did this change by running the following one-liner:
> 
> sed -i 's/    - name: All/    - name: Linux\n    - name: Windows\n    -
> name: MacOSX/g' `find */metainfo.yaml`
> 
> from my frameworks checkout folder in my kdesrc-build subdirectory.

+2
 
> Now, my question is, how shall I proceed in terms of reviewing? Of cause I
> could "simply" fill about 70 review requests. Or I could just grab some KF5
> developer who is currently in Randa to watch over my shoulders when
> committing this and bypassing reviewboard.
> 
> Suggestions?

I would say:
* make sure you have no other pending change in any framework
(e.g. running http://www.davidfaure.fr/2016/git_st_all)
* write a loop that runs the above script, commits, pulls and pushes.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list