Review Request 128185: Ensure extraction location to be in subfolder

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/#review96483
-----------------------------------------------------------


Ship it!





src/karchive.cpp (line 864)
<https://git.reviewboard.kde.org/r/128185/#comment65180>

    Maybe output the extraction folder as well (curDirName, before setting it), for the warning to contain all the information?
    I like warnings that simplify debugging ;)


- David Faure


On June 14, 2016, 2:35 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128185/
> -----------------------------------------------------------
> 
> (Updated June 14, 2016, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Behavior change: Switch to Tar's default behavior to avoid extraction
> to arbitrary system locations outside of extraction folder. Instead,
> extract such files to root location in extraction folder.
> 
> 
> Diffs
> -----
> 
>   autotests/karchivetest.h 4b7ecff 
>   autotests/karchivetest.cpp c8abddf 
>   autotests/tar_relative_path_outside_archive.tar.bz2 PRE-CREATION 
>   src/karchive.cpp 5a7cfc6 
> 
> Diff: https://git.reviewboard.kde.org/r/128185/diff/
> 
> 
> Testing
> -------
> 
> See added unit test
> 
> 
> File Attachments
> ----------------
> 
> test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160614/48110929/attachment.html>