Review Request 128185: Ensure extraction location to be in subfolder

Andreas Cord-Landwehr cordlandwehr at kde.org
Tue Jun 14 14:35:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128185/
-----------------------------------------------------------

(Updated Juni 14, 2016, 2:35 nachm.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Adapt to David's suggestion


Repository: karchive


Description
-------

Behavior change: Switch to Tar's default behavior to avoid extraction
to arbitrary system locations outside of extraction folder. Instead,
extract such files to root location in extraction folder.


Diffs (updated)
-----

  autotests/karchivetest.h 4b7ecff 
  autotests/karchivetest.cpp c8abddf 
  autotests/tar_relative_path_outside_archive.tar.bz2 PRE-CREATION 
  src/karchive.cpp 5a7cfc6 

Diff: https://git.reviewboard.kde.org/r/128185/diff/


Testing
-------

See added unit test


File Attachments
----------------

test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2


Thanks,

Andreas Cord-Landwehr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160614/81581329/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list