Review Request 128147: isolate autotests from (installed) production data

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128147/#review96344
-----------------------------------------------------------




autotests/autotestbase.h (line 30)
<https://git.reviewboard.kde.org/r/128147/#comment65113>

    This can be made a static function, not even required to change the tests common base?


- Aleix Pol Gonzalez


On June 10, 2016, 11:20 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128147/
> -----------------------------------------------------------
> 
> (Updated June 10, 2016, 11:20 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> this means
> - doesn't depend on Glass theme anymore
> - doesn't hardcode buildtime paths into tests, making the tests themself
>   relocatable as they lookup data via qtest helpers at runtime
> - allows more precise testing as the isolated test theme can be mangled
>   to our liking
> - makes tests pass without running make install first
> - by switching both tests cases' qstandardpaths into testing mode we
>   won't accidentally use data that we didn't intend to test on
> - changes to production themes will not break test assumptions
> 
> also introduce an AutoTestBase class to derive for both testcases as we
> now have need for a joint copyTheme method which grabs the test data and
> dumps it at the desired target path
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt dd136da51e47b6c6f33bfcef3d52abf88aac90ee 
>   autotests/autotestbase.h PRE-CREATION 
>   autotests/default-testtheme/angry.png PRE-CREATION 
>   autotests/default-testtheme/confused.png PRE-CREATION 
>   autotests/default-testtheme/dog.png PRE-CREATION 
>   autotests/default-testtheme/emoticons.xml PRE-CREATION 
>   autotests/default-testtheme/sad.png PRE-CREATION 
>   autotests/default-testtheme/smile.png PRE-CREATION 
>   autotests/default-testtheme/tongue.png PRE-CREATION 
>   autotests/kemoticontest.cpp fdada9dfdaf9938e48f86face8e60c853ba54da3 
>   autotests/ktexttohtmlplugintest.cpp 9326430f0a4e6545c4507ec9b4dfe64414dd0e4b 
> 
> Diff: https://git.reviewboard.kde.org/r/128147/diff/
> 
> 
> Testing
> -------
> 
> make && test && install => all good
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160610/dfb90cba/attachment.html>