<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128147/">https://git.reviewboard.kde.org/r/128147/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128147/diff/1/?file=468275#file468275line30" style="color: black; font-weight: bold; text-decoration: underline;">autotests/autotestbase.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">copyTheme</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">dir</span><span class="p">,</span> <span class="k">const</span> <span class="n">QDir</span> <span class="o">&</span><span class="n">baseThemeDir</span><span class="p">,</span> <span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">themeName</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This can be made a static function, not even required to change the tests common base?</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 10th, 2016, 11:20 a.m. CEST, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated June 10, 2016, 11:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kemoticons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this means
- doesn't depend on Glass theme anymore
- doesn't hardcode buildtime paths into tests, making the tests themself
relocatable as they lookup data via qtest helpers at runtime
- allows more precise testing as the isolated test theme can be mangled
to our liking
- makes tests pass without running make install first
- by switching both tests cases' qstandardpaths into testing mode we
won't accidentally use data that we didn't intend to test on
- changes to production themes will not break test assumptions
also introduce an AutoTestBase class to derive for both testcases as we
now have need for a joint copyTheme method which grabs the test data and
dumps it at the desired target path</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make && test && install => all good</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(dd136da51e47b6c6f33bfcef3d52abf88aac90ee)</span></li>
<li>autotests/autotestbase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/angry.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/confused.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/dog.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/emoticons.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/sad.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/smile.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/default-testtheme/tongue.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kemoticontest.cpp <span style="color: grey">(fdada9dfdaf9938e48f86face8e60c853ba54da3)</span></li>
<li>autotests/ktexttohtmlplugintest.cpp <span style="color: grey">(9326430f0a4e6545c4507ec9b4dfe64414dd0e4b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128147/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>