Review Request 128119: Explicitly declare methods as overridden

Andreas Cord-Landwehr cordlandwehr at kde.org
Tue Jun 7 15:10:38 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128119/
-----------------------------------------------------------

(Updated June 7, 2016, 5:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
-------

Submitted with commit 2ba435376571f1c85457353260b7bc2fcf4f5b9c by Andreas Cord-Landwehr to branch master.


Repository: knewstuff


Description
-------

Also remove virtual, since this is inheritated by the parent and
override states clearly that these are overriden methods.


Diffs
-----

  src/ui/itemsviewbasedelegate_p.h 5b20f684b04e017b859e9aebdd34b52c1d298741 

Diff: https://git.reviewboard.kde.org/r/128119/diff/


Testing
-------


Thanks,

Andreas Cord-Landwehr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/3be7caad/attachment.html>


More information about the Kde-frameworks-devel mailing list