Review Request 128119: Explicitly declare methods as overridden

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jun 7 13:46:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128119/#review96259
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On June 7, 2016, 3:40 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128119/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 3:40 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Also remove virtual, since this is inheritated by the parent and
> override states clearly that these are overriden methods.
> 
> 
> Diffs
> -----
> 
>   src/ui/itemsviewbasedelegate_p.h 5b20f684b04e017b859e9aebdd34b52c1d298741 
> 
> Diff: https://git.reviewboard.kde.org/r/128119/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160607/e80660c6/attachment.html>


More information about the Kde-frameworks-devel mailing list