Review Request 128510: KNewFileMenu: fix copying template file from embedded resource
Chinmoy Ranjan Pradhan
chinmoyrp65 at gmail.com
Sun Jul 24 02:04:25 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128510/#review97785
-----------------------------------------------------------
I wonder if this could be fixed in the lower stack.
- Chinmoy Ranjan Pradhan
On July 23, 2016, 7:09 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128510/
> -----------------------------------------------------------
>
> (Updated July 23, 2016, 7:09 p.m.)
>
>
> Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and David Faure.
>
>
> Bugs: 359581
> https://bugs.kde.org/show_bug.cgi?id=359581
>
>
> Repository: kio
>
>
> Description
> -------
>
> KIO::storedTransferJob apparently doesn't support copying "files" from embedded Qt resources.
> Therefore creating a new file via the "Create New" context menu results in an empty file in that case.
>
> This patch fixes it by reading the source file into a QByteArray buffer first.
>
>
> Diffs
> -----
>
> src/filewidgets/knewfilemenu.cpp 4908e4c
>
> Diff: https://git.reviewboard.kde.org/r/128510/diff/
>
>
> Testing
> -------
>
> Use "Create New"->"Text File" or "Create New"->HTML File" (in dolphin or the folderview plasmoid).
> Before only an empty file was created, now the file has the intended content, and therefore the mimetype is also recognized correctly if it has no extension.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160724/910f33d7/attachment.html>
More information about the Kde-frameworks-devel
mailing list