Review Request 128442: [KIconDialog] Allow showing icons from all categories

[Christoph Feck]

> On July 13, 2016, 8:35 p.m., Kai Uwe Broulik wrote:
> > src/kicondialog.cpp, line 302
> > <https://git.reviewboard.kde.org/r/128442/diff/1/?file=471675#file471675line302>
> >
> >     While at it, can we get the size of the array instead of hardcoding a number here?

Good idea, fixed.


> On July 13, 2016, 8:35 p.m., Kai Uwe Broulik wrote:
> > src/kicondialog.cpp, line 368
> > <https://git.reviewboard.kde.org/r/128442/diff/1/?file=471675#file471675line368>
> >
> >     So, I18NC has different order from i18nc? interesting.

Actually not. Initially, I had the arguments reversed, but that caused the combobox to show the context "Icons from all Categories".

While adding context to "Emblems", I noticed that I18NC_NOOP is actually broken; it simply adds both strings to the array.

I removed the context (as it breaks the automatic combo box size), until someone suggests a way to fix it.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128442/#review97356
-----------------------------------------------------------


On July 13, 2016, 8:01 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128442/
> -----------------------------------------------------------
> 
> (Updated July 13, 2016, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 216653
>     https://bugs.kde.org/show_bug.cgi?id=216653
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> - Add an "All" category, which shows icons from all categories
> - Remove "Filesystems" category, which is obsolete and replaced with "Places" category
> - Remove "International" category, which does not contain any icons
> 
> Seeking feedback, especially about the "International" category.
> 
> 
> Diffs
> -----
> 
>   src/kicondialog.cpp cca4ed3 
> 
> Diff: https://git.reviewboard.kde.org/r/128442/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160713/f2cfcdc4/attachment-0001.html>