Review Request 128442: [KIconDialog] Allow showing icons from all categories

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128442/#review97356
-----------------------------------------------------------



Good idea. Sorry for abusing this review for commenting on unrelated issues.


src/kicondialog.cpp (line 302)
<https://git.reviewboard.kde.org/r/128442/#comment65716>

    While at it, can we get the size of the array instead of hardcoding a number here?



src/kicondialog.cpp (line 357)
<https://git.reviewboard.kde.org/r/128442/#comment65718>

    What about this category? It's empty for Breeze and used to contain only silly spinny animations which aren't too useful?



src/kicondialog.cpp (line 361)
<https://git.reviewboard.kde.org/r/128442/#comment65719>

    Can we get a context here, maybe? In German it's translated as "Logos" which isn't what these are about, they're "badges" or "small overlays" for icons.



src/kicondialog.cpp (line 366)
<https://git.reviewboard.kde.org/r/128442/#comment65717>

    So, I18NC has different order from i18nc? interesting.


- Kai Uwe Broulik


On Juli 13, 2016, 8:01 nachm., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128442/
> -----------------------------------------------------------
> 
> (Updated Juli 13, 2016, 8:01 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 216653
>     https://bugs.kde.org/show_bug.cgi?id=216653
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> - Add an "All" category, which shows icons from all categories
> - Remove "Filesystems" category, which is obsolete and replaced with "Places" category
> - Remove "International" category, which does not contain any icons
> 
> Seeking feedback, especially about the "International" category.
> 
> 
> Diffs
> -----
> 
>   src/kicondialog.cpp cca4ed3 
> 
> Diff: https://git.reviewboard.kde.org/r/128442/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160713/45caff84/attachment.html>