Review Request 128336: KNS3::Entry::size: Make sure we offer a size

Aleix Pol Gonzalez aleixpol at kde.org
Sat Jul 2 16:20:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128336/
-----------------------------------------------------------

(Updated July 2, 2016, 6:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Dan Leinir Turthra Jensen and Jeremy Whiting.


Changes
-------

Submitted with commit fc2e7f5865df1c2bd83dced01ba046b76382ce5b by Aleix Pol to branch master.


Bugs: 364896
    https://bugs.kde.org/show_bug.cgi?id=364896


Repository: knewstuff


Description
-------

If there's no downloadable content, return 0. Better than crashing.


Diffs
-----

  src/entry.cpp 1971290 

Diff: https://git.reviewboard.kde.org/r/128336/diff/


Testing
-------

Tests still pass, discover still works. See bug report.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/59c7afc1/attachment.html>


More information about the Kde-frameworks-devel mailing list