Review Request 128336: KNS3::Entry::size: Make sure we offer a size

Andreas Cord-Landwehr cordlandwehr at kde.org
Sat Jul 2 16:06:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128336/#review97028
-----------------------------------------------------------


Ship it!




Ship It!

- Andreas Cord-Landwehr


On Juli 2, 2016, 1:26 nachm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128336/
> -----------------------------------------------------------
> 
> (Updated Juli 2, 2016, 1:26 nachm.)
> 
> 
> Review request for KDE Frameworks, Dan Leinir Turthra Jensen and Jeremy Whiting.
> 
> 
> Bugs: 364896
>     https://bugs.kde.org/show_bug.cgi?id=364896
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> If there's no downloadable content, return 0. Better than crashing.
> 
> 
> Diffs
> -----
> 
>   src/entry.cpp 1971290 
> 
> Diff: https://git.reviewboard.kde.org/r/128336/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, discover still works. See bug report.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/2b12e967/attachment.html>


More information about the Kde-frameworks-devel mailing list