Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

[David Rosca]

> On July 2, 2016, 8:53 a.m., David Faure wrote:
> > Thanks for the very quick fix. Unfortunately I don't know enough about QQuickWidget to approve.
> > 
> > Just wondering: in the testing section, you don't mention that you actually tested runtime behaviour with this change? ;)

Ah sure, I tested it with Qt 5.7 and (apart from that it builds) it seems to work exacty the same as before.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128340/#review97009
-----------------------------------------------------------


On July 2, 2016, 8:44 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128340/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 8:44 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Fixes build with Qt 5.4 after 23b6468fc2486516711ba4ce50f3492fd231d50e
> 
> 
> Diffs
> -----
> 
>   src/kcmoduleqml.cpp 232998f 
> 
> Diff: https://git.reviewboard.kde.org/r/128340/diff/
> 
> 
> Testing
> -------
> 
> Should build fine with Qt 5.4 according to docs. Not tested myself though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/93b0351f/attachment-0001.html>